Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract Registry Challenge #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Abstract Registry Challenge #76

wants to merge 3 commits into from

Conversation

ewilz
Copy link

@ewilz ewilz commented Jul 17, 2018 •
edited
Loading

  • Create ChallengeInterface so that different challenges can easily plug into the registry
  • Create PLCRVotingChallenge contract
  • Create PLCRVotingRegistry which extends Registry and points to PLCRVotingChallengeFactory to create a PLCRVotingChallenge contract for each initiated challenge.

@mikec

@skmgoldin
Copy link
Owner

Wow, thanks for this! Really looking forward to reviewing it.

@akuanti
Copy link
Collaborator

akuanti commented Nov 15, 2018

Can you rebase on master, please?

@ewilz ewilz force-pushed the abstract_registry_challenge branch 5 times, most recently from 73498b3 to fae032e Compare November 28, 2018 16:34
@ewilz ewilz force-pushed the abstract_registry_challenge branch from fae032e to 4e0ec95 Compare November 28, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewilz @skmgoldin @akuanti @mikec