Skip to content

Commit

Permalink
Delete duplicate class + add matrix jdk for unit test gh build (#138)
Browse files Browse the repository at this point in the history
Signed-off-by: David Kornel <[email protected]>
  • Loading branch information
kornys authored May 16, 2024
1 parent e3d8bb6 commit fb74d4c
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 30 deletions.
16 changes: 10 additions & 6 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,26 @@ on:

jobs:
unit-test:
name: unit-test-jdk-${{ matrix.version }}
runs-on: ubuntu-latest
strategy:
matrix:
version: [17, 21]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-java@v3
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '17'
java-version: ${{ matrix.version }}

- name: Cache m2 repo
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
key: ${{ runner.os }}-${{ matrix.version }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
${{ runner.os }}-${{ matrix.version }}-maven-
- name: Validate with Maven
run: mvn test
Expand Down
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@

<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.release>17</maven.compiler.release>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<fabric8.version>6.12.1</fabric8.version>
<sundrio.version>0.200.0</sundrio.version>
Expand Down
1 change: 1 addition & 0 deletions src/main/java/io/odh/test/Environment.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package io.odh.test;

import io.odh.test.install.InstallTypes;
import io.skodjob.testframe.LoggerUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.yaml.snakeyaml.DumperOptions;
Expand Down
24 changes: 0 additions & 24 deletions src/main/java/io/odh/test/LoggerUtils.java

This file was deleted.

1 change: 1 addition & 0 deletions src/main/java/io/odh/test/OdhConstants.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/
package io.odh.test;

import io.skodjob.testframe.LoggerUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down

0 comments on commit fb74d4c

Please sign in to comment.