Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor odh-e2e to use test-frame and avoid duplication of code #136

Merged
merged 4 commits into from
May 9, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented May 3, 2024

No description provided.

@kornys kornys self-assigned this May 3, 2024
@jiridanek jiridanek self-requested a review May 6, 2024 07:53
@skodjob skodjob deleted a comment from kornys May 6, 2024
@skodjob skodjob deleted a comment from kornys May 6, 2024
@kornys kornys removed the request for review from jiridanek May 6, 2024 08:40
@kornys kornys force-pushed the onboard-test-frame branch 2 times, most recently from dd609cf to 8a3b023 Compare May 7, 2024 06:21
@kornys kornys requested review from Frawless and jiridanek May 7, 2024 09:45
@kornys kornys marked this pull request as ready for review May 7, 2024 09:46
@kornys
Copy link
Member Author

kornys commented May 7, 2024

@Frawless @jiridanek
It is ready for review (I do not plan to merge it now).
Test-frame is used from GH snapshot releases.
Otherwise it should work, Im running tests in jenkins now

@kornys
Copy link
Member Author

kornys commented May 7, 2024

Both jenkins jobs for odh-e2e passed with these changes

pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
Copy link
Collaborator

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that does not work for me. In IntelliJ, when I click Download Sources, I get

Sources not found for: io.skodjob:test-frame-common:0.1.0-20240507.094145-86

And general observation that

KubeResourceManager.getInstance().createResourceWithWait(dsci)

is informative, but quite long ;P

Edit: createOrUpdateResourceWithWait !!!

@kornys
Copy link
Member Author

kornys commented May 7, 2024

One thing that does not work for me. In IntelliJ, when I click Download Sources, I get

Sources not found for: io.skodjob:test-frame-common:0.1.0-20240507.094145-86

And general observation that

KubeResourceManager.getInstance().createResourceWithWait(dsci)

is informative, but quite long ;P

Yeah it is because to github snapshots we do not release sources. So once we switch to maven central when I release next beta release, sources will be available

kornys added 2 commits May 9, 2024 09:02
Signed-off-by: David Kornel <[email protected]>
Signed-off-by: David Kornel <[email protected]>
@kornys kornys merged commit 086b7f9 into main May 9, 2024
2 checks passed
@kornys kornys deleted the onboard-test-frame branch May 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants