-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor odh-e2e to use test-frame and avoid duplication of code #136
Conversation
dd609cf
to
8a3b023
Compare
@Frawless @jiridanek |
src/main/java/io/odh/test/framework/manager/resources/DataScienceClusterResource.java
Outdated
Show resolved
Hide resolved
src/main/java/io/odh/test/framework/manager/resources/DataScienceClusterResource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kornel <[email protected]>
Both jenkins jobs for odh-e2e passed with these changes |
Signed-off-by: David Kornel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that does not work for me. In IntelliJ, when I click Download Sources, I get
Sources not found for: io.skodjob:test-frame-common:0.1.0-20240507.094145-86
And general observation that
KubeResourceManager.getInstance().createResourceWithWait(dsci)
is informative, but quite long ;P
Edit: createOrUpdateResourceWithWait
!!!
Yeah it is because to github snapshots we do not release sources. So once we switch to maven central when I release next beta release, sources will be available |
Signed-off-by: David Kornel <[email protected]>
Signed-off-by: David Kornel <[email protected]>
No description provided.