Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No connection to wifis with SSID length of 32 bytes #218

Open
kisenberg opened this issue Jun 12, 2024 · 2 comments
Open

No connection to wifis with SSID length of 32 bytes #218

kisenberg opened this issue Jun 12, 2024 · 2 comments

Comments

@kisenberg
Copy link

Describe the bug
If a wifi has a SSID with a length of 32 bytes, Bitaxe is not able to connect. Only connections to wifis with SSID up to a length of 31 bytes are possible.

To Reproduce
Steps to reproduce the behavior:

  1. Go to AxeOS settings.
  2. Enter 32 bytes long SSID into field of "WiFi SSID".
  3. Click "Save".
  4. Click "Restart".
  5. Bitaxe displays try to connect the wifi forever.

Expected behavior
A connection to wifis with SSID of 32 bytes length should be possible, because an SSID can be 32 bytes long.

Screenshots & Photos
n/a

Hardware (please complete the following information):

  • Bitaxe HW version: Supra 400
  • Bitaxe HW vendor: D-Central
  • ESP-Miner FW version: 2.1.8
  • Hash Frequency: 490 MhZ
  • Voltage: 1166mV
  • Pool URL, Port, User:

Additional context
n/a
tommywatson pushed a commit to tommywatson/ESP-Miner that referenced this issue Jun 12, 2024
Code clean resulting from looking into skot#218
9bcaa2c
@tommywatson tommywatson mentioned this issue Jun 12, 2024
Merged
@tommywatson
Copy link
Contributor

Unfortunately it looks like we are limited to 31 characters by the esp-idf wifi libraries, the structure defined the ssid attribute as

uint8_t ssid[32]; /**< SSID of target AP. */

Including the null terminator that limits the SSID to 31 characters.

https://github.com/espressif/esp-idf/blob/8760e6d2a7e19913bc40675dd71f374bcd51b0ae/components/esp_wifi/include/esp_wifi_types_generic.h#L354

Georges760 pushed a commit that referenced this issue Jun 18, 2024
@tommywatson
Code clean resulting from looking into #218 (#220)
00a3a0b 
* Code clean resulting from looking into #218

* Fixed asic count

Set canary value for invalid device's asic_count

---------

Co-authored-by: tommy <[email protected]>
tommywatson added a commit to tommywatson/ESP-Miner that referenced this issue Jun 20, 2024
@tommywatson
Code clean resulting from looking into skot#218 (skot#220)
982e45e 
* Code clean resulting from looking into skot#218

* Fixed asic count

Set canary value for invalid device's asic_count

---------

Co-authored-by: tommy <[email protected]>
skot added a commit that referenced this issue Jun 20, 2024
@tommywatson @Georges760
@skot @dadofsambonzuki @yanir99 @tdb3
Fixed fan speed web update #141 (#222)
c011895 
* Fixed fan speed web update #141

These changes fix fan rpm/percent requested and update both on the web

* fix readme

* refactor self_test to be modular for new hardware

* Supra 402 (#221)

* port TCH Supra 402 branch

* refactor TMP1075 (unused?) driver using i2c_master module

* pulled in @BitMaker-hub stratum_task.c DNS changes from PR #185

* removing serial debug

---------

Co-authored-by: Skot <[email protected]>

* adjust share accpeted/rejected functions to take higher level GLOBAL_STATE to fix share accounting.

* Code clean resulting from looking into #218 (#220)

* Code clean resulting from looking into #218

* Fixed asic count

Set canary value for invalid device's asic_count

---------

Co-authored-by: tommy <[email protected]>

* fix another pointer error

* Changes efficiency metric display in AxeOS (#231)

Fixes #230

* try to explain nonce space duration from paramters (#228)

* try to explain nonce space duration from paramters

* Fix Nonce Space duration for BM1397 (no version-rolling)

* fixed issue with version mask on 1397. added easy serial debugging on 1397

* cleanup jobID debugs

---------

Co-authored-by: Skot <[email protected]>

* Update bm1397.c to increase the max frequency to 650Mhz (#209)

* Update bm1397.c to increase the max frequency to 650Mhz

The original version was setting everything above 500Mhz to 500Mhz, the update increases the limit to 650Mhz.
No changes to the web interface - drop-down still shows up to 575Mhz

* Update edit.component.ts to include higher freqeuncy for BM1397

* Updated BM1397 frequencies to above 500Mhz

* Update bm1397.c

* Update bm1397.c

* UN-Update readme.md

* Update bm1397.c

* Update bm1397.c

* Update bm1397.c

* fix: add recovery page (#232)

Adds a recovery web interface to enable users
to recover from a failed www.bin update.
Partial fix for Issue #213.

* refactor: unify merge_bin scripts (#189)

Combines the functionality of merge_bin_update.sh
and merge_bin_with_config.sh into merge_bin.sh.
Also adds more verbose usage printing.

* fix: check www.bin size before updating (#216)

Adds a basic sanity check for www.bin uploading.
Returns 400 if upload is attempted on a file larger
than the available partition space.

---------

Co-authored-by: tommy <[email protected]>
Co-authored-by: Georges Palauqui <[email protected]>
Co-authored-by: Skot <[email protected]>
Co-authored-by: Nathan Day <[email protected]>
Co-authored-by: yanir99 <[email protected]>
Co-authored-by: tdb3 <[email protected]>
@kisenberg
Copy link
Author

So, there will be no chance to change that from 32 bytes to 33 bytes with the null terminator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tommywatson @kisenberg