Add visibility to flaky jobs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fragoulis
approved these changes
Aug 28, 2020
agis
force-pushed
the
gh21-flaky-job-visibility
branch
2 times, most recently
from
4c2cac5
to
4c3e681
Compare
0xdiba
approved these changes
Aug 30, 2020
This method can be called after a build is complete and returns the jobs that were flaky (i.e. failed initially but passed upon a retry). This enables us to provide visibility to flaky tests so that test implementers have a chance to actually fix them. Part of #21
Example output (the new part is just below "Spec execution time"):
Failed examples:
bin/rspec ./test/sample_suites/flaky_job_detection/spec/legit_failure_spec.rb:5 # is expected to equal true
Total results:
13 examples (6 jobs), 1 failures, 0 errors
Spec execution time: 00:00:00
Flaky jobs detected (count=2):
./test/sample_suites/flaky_job_detection/spec/flaky_spec.rb[1:3]
./test/sample_suites/flaky_job_detection/spec/flaky_spec.rb[1:1]
Part of #21
agis
force-pushed
the
gh21-flaky-job-visibility
branch
from
44d6cb0
to
41b41ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches provide visibility to test suite flakiness by:
A preview of the build summary output:
And a preview from the Sentry event:
Closes #21