Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatch aggregate #1116

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Dispatch aggregate #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
e7ce14a
Layout changes for aggregate
TheooJ Oct 12, 2024
0256bd2
Check for columns / operations compatibility
TheooJ Oct 12, 2024
a9513ca
Check operations on aggregated columns only. Let AggJoiner/Target han…
TheooJ Oct 12, 2024
b85184d
Ensure input/orders are the same in polars
TheooJ Oct 12, 2024
28680d1
Handle pandas-nullable-dtypes in aggregate
TheooJ Oct 12, 2024
74406e3
Test multiple operations, add polars operations
TheooJ Oct 12, 2024
a664212
Merge branch 'main' into dispatch_aggregate
TheooJ Oct 12, 2024
44b666a
Add suffix in aggregate
TheooJ Oct 12, 2024
0fe168d
Iter tests, handle case pandas nullable dtypes
TheooJ Oct 12, 2024
8f772cb
Iter tests
TheooJ Oct 12, 2024
386003b
Test unsupported operations. Move operations default to init
TheooJ Oct 13, 2024
366799a
Cleanup
TheooJ Oct 13, 2024
d0e3d61
Pass all AggJoiner tests
TheooJ Oct 13, 2024
9e92bdc
Dispatch aggregate in AggTarget
TheooJ Oct 13, 2024
3154fde
Fix docstring
TheooJ Oct 13, 2024
264a12d
Iter MultiAggJoiner tests
TheooJ Oct 13, 2024
e56b9fc
Change default values, make operations mandatory, don't maintain orde…
TheooJ Oct 15, 2024
20ce71f
Test aggregating polars df irrespective of order
TheooJ Oct 15, 2024
914609f
Error message for col outside of aux_table raised by selectors
TheooJ Oct 15, 2024
b836ed4
Remove aggregate from _pandas and _polars files
TheooJ Oct 16, 2024
e39b50f
check_missing_columns now accepts a selector
TheooJ Oct 16, 2024
efe6393
Adding suffixes don't create duplicate names
TheooJ Oct 16, 2024
032c6f3
Test aggregating multiple cols, boolean cols
TheooJ Oct 16, 2024
8dea5af
Rework MultiAggJoiner tests to avoid raising when using mode in pandas
TheooJ Oct 16, 2024
4f7c262
Cleanup
TheooJ Oct 17, 2024
700a7be
Make operations argument mandatory for MultiAggJoiner
TheooJ Oct 17, 2024
d2109f6
Add changelog entry
TheooJ Oct 17, 2024
452d958
Skip test when polars not installed
TheooJ Oct 17, 2024
ea1aa15
Merge remote-tracking branch 'upstream/main' into dispatch_aggregate
TheooJ Oct 20, 2024
8ed6c09
Apply suggestions from code review
TheooJ Oct 22, 2024
dbcef1d
Apply suggestions from code review
TheooJ Oct 22, 2024
73374d5
Apply suggestions from code review
TheooJ Oct 22, 2024
7f0bccc
Fix docstring
TheooJ Oct 22, 2024
743c4e0
Update changelog
TheooJ Oct 22, 2024
8fa5333
Apply suggestions from code review
TheooJ Oct 22, 2024
8e8afa0
Test supported operations, leave checks out of aggregate
TheooJ Oct 22, 2024
b627cd8
Simplify AggJoiner check inputs
TheooJ Oct 23, 2024
7b1f291
Rename operation -> operations in AggTarget
TheooJ Oct 23, 2024
e59d410
Make operations mandatory in AggTarget
TheooJ Oct 23, 2024
0cf1c52
Set default value to suffix='_target' in AggTarget
TheooJ Oct 23, 2024
d5b18a6
Remove default operations value in AggTarget
TheooJ Oct 23, 2024
1028b8e
Explicitely mention joiners in test names
TheooJ Oct 23, 2024
29ddaa2
Iter dispatch aggregate
TheooJ Oct 23, 2024
a0b3fd3
Iter dispatch & cleaning
TheooJ Oct 23, 2024
16cb467
Add get_feature_names_out method for AggJoiner
TheooJ Oct 25, 2024
1748726
Test AggTarget operations, suffix
TheooJ Oct 25, 2024
e5031d9
Add get_feature_names_out method for AggTarget
TheooJ Oct 25, 2024
29837cc
Iter AggTarget tests
TheooJ Oct 25, 2024
49564e9
Iter docstring
TheooJ Oct 25, 2024
b6a57b9
Iter AggTarget y inputs
TheooJ Oct 25, 2024
1e024c8
Test multiple targets
TheooJ Oct 25, 2024
7688e3c
Iter AggTarget tests
TheooJ Oct 25, 2024
773c772
Add docstrings to get_feature_names_out
TheooJ Oct 28, 2024
6303033
Merge remote-tracking branch 'upstream/main' into dispatch_aggregate
TheooJ Oct 29, 2024
0f5e24f
Fix AggTarget tests
TheooJ Oct 29, 2024
d80b18f
Iter AggTarget tests
TheooJ Oct 29, 2024
5b98c8b
Iter AggTarget tests
TheooJ Oct 30, 2024
1cd2cea
Cover case 1d array
TheooJ Oct 30, 2024
1533755
Cover case 1d array
TheooJ Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ New features
Major changes
-------------

* AggJoiner, AggTarget and MultiAggJoiner now require the `operations` argument. They do not
split columns by type anymore, but apply `operations` on all selected cols. "median" is now
supported, "hist" and "value_counts" are no longer supported. :pr:`1116`
by :user:`Théo Jolivet <TheooJ>`.

Minor changes
-------------

Expand Down
Loading