convert mixed column types to string #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoGrin
changed the title
|
|
||
| def test_mixed_types(): | ||
| # TODO: datetime/str mixed types | ||
| # don't work |
There was a problem hiding this comment.
no, it seems to require a bit more work, and I was wondering whether such mixed types could really appear in the wild
|
no, it seems to require a bit more work, and I was wondering whether such mixed types could really appear in the wild
ok, let's punt then
|
…ns with a slow pandas apply
skrub/_table_vectorizer.py
Outdated
| @@ -477,6 +478,11 @@ def _auto_cast(self, X: pd.DataFrame) -> pd.DataFrame: | |||
| X[col] = X[col].astype(np.float64) | |||
| X[col].fillna(value=np.nan, inplace=True) | |||
|
|
|||
| # if object, first convert to string to avoid mixed types | |||
| for col in X.columns: | |||
| if pd.api.types.is_object_dtype(X[col]): | |||
There was a problem hiding this comment.
Is this necessary, or can we just look at X.dtypes (at least in the case that X is a dataframe)? I suspect that X.dtypes is less costly than is_object_dtypes. It's also more of a first-level API and thus I suspect that it is more likely to generalize across dataframe implementations.
LeoGrin
added a commit
that referenced
this pull request
Jul 20, 2023
(Sorry I think I messed up when applying a suggestion for #623 )
LeoGrin
added a commit
that referenced
this pull request
Jul 20, 2023
(Sorry I think I messed up when applying a suggestion for #623 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #622, which was due to mixed types column.