Skip to content

Commit

Permalink
stmmac: intel: Fix an error handling path in intel_eth_pci_probe()
Browse files Browse the repository at this point in the history
When the managed API is used, there is no need to explicitly call
pci_free_irq_vectors().

This looks to be a left-over from the commit in the Fixes tag. Only the
.remove() function had been updated.

So remove this unused function call and update goto label accordingly.

Fixes: 8accc46 ("stmmac: intel: use managed PCI function on probe and resume")
Signed-off-by: Christophe JAILLET <[email protected]>
Reviewed-by: Wong Vee Khee <[email protected]>
Link: https://lore.kernel.org/r/1ac9b6787b0db83b0095711882c55c77c8ea8da0.1654462241.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Paolo Abeni <[email protected]>
  • Loading branch information
tititiou36 authored and Paolo Abeni committed Jun 7, 2022
1 parent b8d9139 commit 5e74a4b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1072,13 +1072,11 @@ static int intel_eth_pci_probe(struct pci_dev *pdev,

ret = stmmac_dvr_probe(&pdev->dev, plat, &res);
if (ret) {
goto err_dvr_probe;
goto err_alloc_irq;
}

return 0;

err_dvr_probe:
pci_free_irq_vectors(pdev);
err_alloc_irq:
clk_disable_unprepare(plat->stmmac_clk);
clk_unregister_fixed_rate(plat->stmmac_clk);
Expand Down

0 comments on commit 5e74a4b

Please sign in to comment.