Skip to content

Commit

Permalink
amt: fix return value of amt_update_handler()
Browse files Browse the repository at this point in the history
If a relay receives an update message, it lookup a tunnel.
and if there is no tunnel for that message, it should be treated
as an error, not a success.
But amt_update_handler() returns false, which means success.

Fixes: cbc21dc ("amt: add data plane of amt interface")
Signed-off-by: Taehee Yoo <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
TaeheeYoo authored and kuba-moo committed May 26, 2022
1 parent 4934609 commit ac1dbf5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/amt.c
Original file line number Diff line number Diff line change
Expand Up @@ -2423,7 +2423,7 @@ static bool amt_update_handler(struct amt_dev *amt, struct sk_buff *skb)
}
}

return false;
return true;

report:
iph = ip_hdr(skb);
Expand Down

0 comments on commit ac1dbf5

Please sign in to comment.