Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential deadlock when reading listener operStatus in TCP adaptor #1192

Closed
kgiusti opened this issue Sep 11, 2023 · 0 comments · Fixed by #1193
Closed

Potential deadlock when reading listener operStatus in TCP adaptor #1192

kgiusti opened this issue Sep 11, 2023 · 0 comments · Fixed by #1193
Assignees
Milestone

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Sep 11, 2023

WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=7531)
Cycle in lock order graph: M396 (0x7b400001ee40) => M593 (0x7b3000068d08) => M396

Mutex M593 acquired here while holding mutex M396 in thread T6:
#0 pthread_mutex_lock <null> (libtsan.so.2+0x56341)
#1 sys_mutex_lock /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:53 (skrouterd+0x480938)
#2 qd_adaptor_listener_oper_status /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/adaptor_listener.c:397 (skrouterd+0x480938)
#3 qd_entity_refresh_tcpListener_lite /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_lite/tcp_lite.c:1664 (skrouterd+0x480938)
#4 qd_entity_refresh_tcpListener /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/adaptor_common.c:384 (skrouterd+0x4660ad)
#5 ffi_call_unix64 <null> (libffi.so.8+0x7a05)
#6 qdr_forward_on_message /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/forwarder.c:375 (skrouterd+0x4e1b88)
#7 qdr_general_handler /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/router_core.c:1004 (skrouterd+0x4ebcc9)
#8 qd_timer_visit /home/runner/work/skupper-router/skupper-router/skupper-router/src/timer.c:318 (skrouterd+0x5202b1)
#9 handle /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1014 (skrouterd+0x5242ec)
#10 thread_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1143 (skrouterd+0x525c85)
#11 _thread_init /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:206 (skrouterd+0x4a5abd)

Mutex M396 previously acquired by the same thread here:
#0 pthread_mutex_lock <null> (libtsan.so.2+0x56341)
#1 sys_mutex_lock /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:53 (skrouterd+0x480919)
#2 qd_entity_refresh_tcpListener_lite /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_lite/tcp_lite.c:1663 (skrouterd+0x480919)
#3 qd_entity_refresh_tcpListener /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/adaptor_common.c:384 (skrouterd+0x4660ad)
#4 ffi_call_unix64 <null> (libffi.so.8+0x7a05)
#5 qdr_forward_on_message /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/forwarder.c:375 (skrouterd+0x4e1b88)
#6 qdr_general_handler /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/router_core.c:1004 (skrouterd+0x4ebcc9)
#7 qd_timer_visit /home/runner/work/skupper-router/skupper-router/skupper-router/src/timer.c:318 (skrouterd+0x5202b1)
#8 handle /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1014 (skrouterd+0x5242ec)
#9 thread_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1143 (skrouterd+0x525c85)
#10 _thread_init /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:206 (skrouterd+0x4a5abd)

Mutex M396 acquired here while holding mutex M593 in thread T6:
#0 pthread_mutex_lock <null> (libtsan.so.2+0x56341)
#1 sys_mutex_lock /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:53 (skrouterd+0x47e2bd)
#2 on_accept /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_lite/tcp_lite.c:1378 (skrouterd+0x47e2bd)
#3 _listener_event_handler /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/adaptor_listener.c:152 (skrouterd+0x47ac23)
#4 _listener_event_handler /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/adaptor_listener.c:121 (skrouterd+0x47ac23)
#5 handle_event_with_context /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:811 (skrouterd+0x52436d)
#6 do_handle_raw_connection_event /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:817 (skrouterd+0x52436d)
#7 handle /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1098 (skrouterd+0x52436d)
#8 thread_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1143 (skrouterd+0x525c85)
#9 _thread_init /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:206 (skrouterd+0x4a5abd)

Mutex M593 previously acquired by the same thread here:
#0 pthread_mutex_lock <null> (libtsan.so.2+0x56341)
#1 sys_mutex_lock /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:53 (skrouterd+0x47abe4)
#2 _listener_event_handler /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/adaptor_listener.c:150 (skrouterd+0x47abe4)
#3 _listener_event_handler /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/adaptor_listener.c:121 (skrouterd+0x47abe4)
#4 handle_event_with_context /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:811 (skrouterd+0x52436d)
#5 do_handle_raw_connection_event /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:817 (skrouterd+0x52436d)
#6 handle /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1098 (skrouterd+0x52436d)
#7 thread_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1143 (skrouterd+0x525c85)
#8 _thread_init /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:206 (skrouterd+0x4a5abd)

Thread T6 'wrkr_3' (tid=7540, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.2+0x5f0e6)
#1 sys_thread /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:228 (skrouterd+0x4a81ca)
#2 qd_server_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1515 (skrouterd+0x5265a9)
#3 main_process /home/runner/work/skupper-router/skupper-router/skupper-router/router/src/main.c:111 (skrouterd+0x42bbe0)
#4 main /home/runner/work/skupper-router/skupper-router/skupper-router/router/src/main.c:365 (skrouterd+0x427afe)

SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) (/lib64/libtsan.so.2+0x56341) in __interceptor_pthread_mutex_lock
@kgiusti kgiusti self-assigned this Sep 11, 2023
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Sep 11, 2023
@kgiusti kgiusti linked a pull request Sep 11, 2023 that will close this issue
jiridanek pushed a commit to jiridanek/skupper-router that referenced this issue Sep 19, 2023
@ganeshmurthy ganeshmurthy added this to the 2.5.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants