Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1563 #1601

Merged
merged 20 commits into from
Aug 16, 2024
Merged

Issue 1563 #1601

merged 20 commits into from
Aug 16, 2024

Conversation

ganeshmurthy
Copy link
Contributor

No description provided.

…y on deletion of tcpListener and tcpConnector

Signed-off-by: Gabor Dozsa <[email protected]>
Copy link
Contributor

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo inline suggestions

src/adaptors/tcp/tcp_adaptor.c Outdated Show resolved Hide resolved
src/adaptors/tcp/tcp_adaptor.c Outdated Show resolved Hide resolved
src/adaptors/tcp/tcp_adaptor.c Show resolved Hide resolved
src/adaptors/tcp/tcp_adaptor.c Show resolved Hide resolved
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 93.99142% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (1b1d4b9) to head (f6c04a4).
Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1601      +/-   ##
========================================
+ Coverage   63.0%   78.0%   +15.0%     
========================================
  Files        214     253      +39     
  Lines      51857   64979   +13122     
  Branches    5986    6197     +211     
========================================
+ Hits       32681   50701   +18020     
+ Misses     16966   11453    -5513     
- Partials    2210    2825     +615     
Flag Coverage Δ
pysystemtests 87.0% <98.1%> (+8.7%) ⬆️
systemtests 71.1% <83.8%> (+15.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
unittests 78.0% <81.5%> (+15.0%) ⬆️
systemtests 78.0% <81.5%> (+15.0%) ⬆️

@ganeshmurthy ganeshmurthy merged commit e50c2d5 into skupperproject:main Aug 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants