Tcplistener observer #1624
Open
Tcplistener observer #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshmurthy
force-pushed
the
TCPLISTENER-OBSERVER
branch
from
356f24b
to
87d81d2
Compare
ted-ross
requested changes
Oct 9, 2024
| listener->protocol_observer_config = 0; | ||
| listener->protocol_observer = 0; | ||
| } | ||
| } else if (!listener->protocol_observer) { |
There was a problem hiding this comment.
Possible bug: If the observer for a listener is being changed, this IF clause will not match and the observer will not be updated.
There was a problem hiding this comment.
_setup_protocol_observer_LH() only handles setting up or tearing down of listener->protocol_observer when the observer goes from none to non-none or vice versa.
The observer is actually updated in qd_dispatch_update_tcp_listener()
Please let me know if that made sense ?
… entity so observers can be directly specified or auto detected
ganeshmurthy
force-pushed
the
TCPLISTENER-OBSERVER
branch
from
19cb6be
to
423a5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.