Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #420 - Decrease per-test pytest timeout to 100 #456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Contributor

@jiridanek jiridanek commented May 9, 2022

@jiridanek jiridanek changed the title Issue # 420 - Decrease per-test pytest timeout to 100 Issue #420 - Decrease per-test pytest timeout to 100 May 9, 2022
@jiridanek jiridanek marked this pull request as ready for review May 25, 2022 18:35
@jiridanek jiridanek force-pushed the jd_2022_04_30_pytest_moar_powar_timeout branch from 2853f1a to 0e0604b Compare June 1, 2022 21:45
@jiridanek jiridanek force-pushed the jd_2022_04_30_pytest_moar_powar_timeout branch from 0e0604b to 528efee Compare August 5, 2022 17:57
@jiridanek jiridanek force-pushed the jd_2022_04_30_pytest_moar_powar_timeout branch from 528efee to 2ce0602 Compare September 1, 2022 13:43
@jiridanek jiridanek force-pushed the jd_2022_04_30_pytest_moar_powar_timeout branch from 2ce0602 to 5a0fdee Compare April 1, 2023 17:23
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #456 (7750dbb) into main (acd49e4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   76.71%   76.70%   -0.01%     
==========================================
  Files         247      247              
  Lines       63983    63983              
  Branches     5902     6024     +122     
==========================================
- Hits        49083    49077       -6     
+ Misses      12332    12329       -3     
- Partials     2568     2577       +9     
Flag Coverage Δ
pysystemtests 87.73% <ø> (ø)
pyunittests 54.60% <ø> (ø)
systemtests 69.48% <ø> (-0.03%) ⬇️
unittests 21.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
calculator 25.99% <ø> (+<0.01%) ⬆️
systemtests 77.37% <ø> (-0.02%) ⬇️

@jiridanek jiridanek force-pushed the jd_2022_04_30_pytest_moar_powar_timeout branch from 5a0fdee to 92373cb Compare May 15, 2023 15:08
@ganeshmurthy
Copy link
Contributor

@jiridanek do you still want to do this ? Going from 400 to 100 ? I would rather not do this and find out that we need to move it back up again ?

@jiridanek jiridanek force-pushed the jd_2022_04_30_pytest_moar_powar_timeout branch from 92373cb to a1273af Compare June 9, 2023 16:24
@jiridanek
Copy link
Contributor Author

@jiridanek do you still want to do this ? Going from 400 to 100 ? I would rather not do this and find out that we need to move it back up again ?

@ganeshmurthy This timeout is the default per-test timeout in pytest, so if you write a single python test method that takes more than 100 seconds, you can

  1. split it into multiple test methods
  2. add some pytest annotation to extend the timeout for this specific test method

IIRC, when this PR was newly created, there was one or two tests exceeding the 100 seconds, and I suspected in both cases it is because of some test bug, I don't exactly recall what it was. Looks like there is a few tests going over the 100 seconds.

I'll try to look why they take that much time and if they truly need it, or if there is something wrong going on.

@jiridanek jiridanek force-pushed the jd_2022_04_30_pytest_moar_powar_timeout branch from a1273af to 7750dbb Compare December 27, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants