Name of cert token based on site UID #1256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grs
reviewed
Nov 3, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| secret, localOnly, err := cli.ConnectorTokenCreate(ctx, fmt.Sprintf("%s-%s", subject, siteConfig.Reference.UID), "") |
There was a problem hiding this comment.
Ideally we would separate the name used in the secret yaml from the subject used in the client certificate within that secret.
There was a problem hiding this comment.
LGTM. I can move the concatenation of subject and site UID into ConnectorTokenCreate, but the function is called at several points in the code (e.g. newGateway and GatewayGenerateBundle). The alternative could be to change the signature of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to resolve #1154 adding site UID to the token secret name.