-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Skupper Helm chart #1627
base: v2
Are you sure you want to change the base?
Basic Skupper Helm chart #1627
Conversation
@@ -0,0 +1,223 @@ | |||
--- | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the helm chart install namespace or cluster scoped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more interesting if the helm chart allows user to choose the target scope?
It could assume cluster scope by default but offer a flag (--set scope=namespace
for example)
to change the default scope?
env: | ||
- name: SKUPPER_ENABLE_GRANTS | ||
value: "true" | ||
- name: SKUPPER_CLAIMS_GET_BASE_URL_FROM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration has changed a little recently and is now simpler and the Certificate and SecuredAccess resources are no longer required.
@@ -0,0 +1,102 @@ | |||
apiVersion: apiextensions.k8s.io/v1 | |||
kind: CustomResourceDefinition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the CRDs would be defined in one place or copied by the build. Otherwise it is easy to make changes to one copy and not the other.
@@ -0,0 +1,3 @@ | |||
replicaCount: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed?
@@ -0,0 +1,223 @@ | |||
--- | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more interesting if the helm chart allows user to choose the target scope?
It could assume cluster scope by default but offer a flag (--set scope=namespace
for example)
to change the default scope?
It would be nice if we can merge this PR that community can use the helm chart. |
Description
This Helm chart is designed to simplify the deployment of Skupper in a Kubernetes namespace.
It ensures that the Skupper Custom Resource Definitions (CRDs) and the Skupper controller
are correctly installed and configured.
Usage:
To deploy Skupper using this Helm chart, simply run the following command, specifying your
namespace:
If the namespace is not specified it will be deployed in the current namespace.
How to uninstall the helm chart