Fix handling of enable-console option

[grs]

No description provided.

[fgiorgetti]

Unit tests are passing using both mock and real cluster.
I have also verified --enable-console=true and --enable-console=false using the skupper command and it is working properly as well.

One comment or suggestion would be to allow modifying --enable-console value through SiteConfigUpdate so users can enable the console on an already initialized namespace, if needed. If you think it is a good idea, I can raise an issue.

[grs]

One comment or suggestion would be to allow modifying --enable-console value through SiteConfigUpdate so users can enable the console on an already initialized namespace, if needed. If you think it is a good idea, I can raise an issue.

I agree that would be a useful enhancement. (The intention is eventually that all aspects can be updated)

[fgiorgetti]

One comment or suggestion would be to allow modifying --enable-console value through SiteConfigUpdate so users can enable the console on an already initialized namespace, if needed. If you think it is a good idea, I can raise an issue.

I agree that would be a useful enhancement. (The intention is eventually that all aspects can be updated)

And I believe this is going to be addressed by an existing issue #58. Thank you!

[ajssmith]

iiuc, intent is the console should be enabled by default, should default be changed from false to true in cmd/skupper/skupper.go?

Otherwise, user will need to '--enable-console on init'

[grs]

iiuc, intent is the console should be enabled by default, should default be changed from false to true in cmd/skupper/skupper.go?

Yes! Had not realised that it was off by default there. Previously the flag was not properly honoured so would always be on regardless. With this fix though we do need to change the default which I have now done.

Well spotted!

[ajssmith]

lgtm

built and tried true/false on OpenShift and minikube.