WIP: Tests for #821: unexpose leaving previous K8S service unusable #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hash-d
commented
Dec 2, 2022
hash-d
commented
- add service expose/unexpose to hello_world (in addition to deployment expose/unexpose)
- add actual service use checks on hello_world (previously, it was only checking skupper structure, not use)
- introduce CurlTester to test/utils/skupper/cli
hash-d
force-pushed
the
dh-skupper-314
branch
from
29bfbfa
to
0ea7a9e
Compare
hash-d
changed the title
fgiorgetti
reviewed
Dec 7, 2022
| Ports: ports, | ||
| Selector: selector, | ||
| Type: apiv1.ServiceTypeLoadBalancer, | ||
| }, |
There was a problem hiding this comment.
It might be safer to create the service with ClusterIP, as depending on where the test is run
it won't get an IP.
CurlTester now can retry and expect failures instead of successes
hash-d
force-pushed
the
dh-skupper-314
branch
from
0ea7a9e
to
ed9a257
Compare
hash-d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.