Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support scopes properly. #124

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Support scopes properly. #124

merged 2 commits into from
Feb 14, 2020

Commits on Feb 14, 2020

  1. Support scopes properly. 

    Currently the variables set in our `foreach` handler live
forever, potentially overwriting global variables with the
same names.

This pull-request will close #123 by handling scope for this
case correctly:

* The variable(s) set in the foreach statement will only live for the
duration of their enclosing block.
  * This means they'll be unavailable when the block is terminated.
  * And this will work for (deeply) nested loop-iterations.
    @skx
    skx committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    a9bb519 View commit details
    Browse the repository at this point in the history

  2. Create/Use scopes. 

    This is a combination of over-engineered and heuristic-based.

Probably works.
    @skx
    skx committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    ecd8875 View commit details
    Browse the repository at this point in the history