Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Duplicate JMenuItem in Plugin Menu #2206

Closed
1 of 3 tasks
cleanriceking opened this issue Jun 21, 2024 · 1 comment
Closed
1 of 3 tasks

[gui] Duplicate JMenuItem in Plugin Menu #2206

cleanriceking opened this issue Jun 21, 2024 · 1 comment
Assignees
@skylot
Labels
bug GUI Issues in jadx-gui module jadx-plugin
Milestone
TBD

Comments

@cleanriceking
Copy link

Issue details

In the JadxPlugin interface, within the init method, addMenuAction is used. After opening jadx, click on settings and then close it. When loading an APK file, you will find that the plugin menu contains duplicate JMenuItem entries.

The reason is that the public void addToPluginsMenu(Action item) method in MainWindow does not filter out duplicate JMenuItem entries.

Jadx version

1.5.0

Java version

21.0.3

OS

  • Windows
  • Linux
  • macOS
@cleanriceking cleanriceking added bug GUI Issues in jadx-gui module labels Jun 21, 2024
@skylot skylot self-assigned this Jun 28, 2024
@skylot skylot added this to the TBD milestone Jun 28, 2024
skylot added a commit that referenced this issue Oct 25, 2024
@skylot
fix(gui): load plugins settings in temp context without UI (#2206)
37054dc
@skylot
Copy link
Owner

skylot commented Oct 25, 2024

Fixed

@skylot skylot closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skylot skylot

Labels
bug GUI Issues in jadx-gui module jadx-plugin
Projects
None yet
Milestone
TBD
Development

No branches or pull requests
2 participants
@skylot @cleanriceking