[Core] Avoid install python 3.11 conda #2241
Conversation
Michaelvll
changed the title
There was a problem hiding this comment.
Thanks for identifying the issue @Michaelvll! Left a question about skipping some smoke tests.
| @@ -1506,20 +1509,26 @@ def _get_cancel_task_with_cloud(name, cloud, timeout=15 * 60): | |||
|
|
|||
| # ---------- Testing `sky cancel` ---------- | |||
| @pytest.mark.aws | |||
| @pytest.mark.skip( | |||
There was a problem hiding this comment.
Hmm, it seems a bit dangerous to skip these core tests? Maybe we should endure the flakiness for now?
There was a problem hiding this comment.
Should we instead fix #2207 ? It seems to be problematic tests.
There was a problem hiding this comment.
should we mark it as P0? To avoid skipping these core tests for too long.
| @@ -190,7 +190,7 @@ setup_commands: | |||
| pip3 --version > /dev/null 2>&1 || (curl -sSL https://bootstrap.pypa.io/get-pip.py -o get-pip.py && python3 get-pip.py && echo "PATH=$HOME/.local/bin:$PATH" >> ~/.bashrc); | |||
| (type -a python | grep -q python3) || echo 'alias python=python3' >> ~/.bashrc; | |||
| (type -a pip | grep -q pip3) || echo 'alias pip=pip3' >> ~/.bashrc; | |||
| (which conda > /dev/null 2>&1 && conda init > /dev/null) || (wget -nc https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh && bash Miniconda3-latest-Linux-x86_64.sh -b && eval "$(~/miniconda3/bin/conda shell.bash hook)" && conda init && conda config --set auto_activate_base true); | |||
There was a problem hiding this comment.
These couple of j2 seem to have 2 - 3 versions. (e.g., some have conda init > /dev/null, some don't). I guess if smoke tests all passed (does it by default cover all tests?) it's ok to use 1 version?
There was a problem hiding this comment.
It should be fine. The only difference between the two versions is just having conda init after the which conda at the beginning. Theoretically, it should not affect anything. We now have the conda init everywhere, and tested with pytest tests/test_smoke.py (on GCP) which indicates adding the conda init indeed does not cause problem.
…installing-python311
Partially fixes #2240, for the images without conda installed by default.
This PR also updates the tf version for tpu tests as the TPU no longer support the old version of Tensorflow https://cloud.google.com/tpu/docs/supported-tpu-configurations#tensorflow_2
Confirmed that this PR fixes the TPU VM issue, as the original image of the TPU VM does not have conda installed by default.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py --aws