Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query cloud specific env vars in task setup #2334

Closed
wants to merge 2 commits into from

Conversation

hemildesai
Copy link
Contributor

@hemildesai hemildesai commented Aug 1, 2023

Adds a class method to Cloud called query_env_vars which can query cloud specific env vars. Addresses #2287

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Ran sky launch -- printenv and verified that KUBERNETES_SERVICE_PORT etc are included
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@romilbhardwaj romilbhardwaj deleted the branch skypilot-org:k8s_cloud August 2, 2023 10:57
@romilbhardwaj
Copy link
Collaborator

Thanks @hemildesai! This PR got closed when we merged #2096 into master.

For our next sprint, we'll be switching to k8s_cloud_beta1 branch. Can you re-open this PR on that branch?

@hemildesai
Copy link
Contributor Author

Couldn't reopen this so created #2347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants