remove additional comment

skyplane-project · Oct 12, 2022 · 4ce066d · 4ce066d
1 parent 928fdac
commit 4ce066d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/skyplane/compute/aws/aws_cloud_provider.py b/skyplane/compute/aws/aws_cloud_provider.py
@@ -73,7 +73,7 @@ def get_instance_list(self, region: str) -> List[AWSServer]:
             logger.error(f"error provisioning in {region}: {e}")
             return []
 
-        return [AWSServer(f"aws:{region}", i) for i in instance_ids]  # TODO: this is wrong, just for checking
+        return [AWSServer(f"aws:{region}", i) for i in instance_ids]  
 
     def get_security_group(self, region: str, vpc_name="skyplane", sg_name="skyplane"):
         ec2 = self.auth.get_boto3_resource("ec2", region)
@@ -294,7 +294,6 @@ def remove_ips_from_security_group(self, aws_region: str, ips: List[str]):
         sg = self.get_security_group(aws_region)
         try:
             logger.fs.debug(f"[AWS] Removing IPs {ips} from security group {sg.group_name}")
-            # TODO: might need to revoke ingress if ips are None
             sg.revoke_ingress(
                 IpPermissions=[
                     {"IpProtocol": "tcp", "FromPort": 12000, "ToPort": 65535, "IpRanges": [{"CidrIp": ip + "/32"}]} for ip in ips