Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[on-prem] Fallback logic to S3 shouldn't follow symlinks #560

Closed
parasj opened this issue Sep 19, 2022 · 0 comments · Fixed by #562
Closed

[on-prem] Fallback logic to S3 shouldn't follow symlinks #560

parasj opened this issue Sep 19, 2022 · 0 comments · Fixed by #562
Assignees
@ShishirPatil
Labels
bug Something isn't working

Comments

@parasj
Copy link
Contributor

parasj commented Sep 19, 2022

Currently, the fallback to aws s3 sync will trace symlinks through directories. Instead, update the command to use aws s3 sync --no-follow-symlinks.
@parasj parasj added the bug Something isn't working label Sep 19, 2022
@ShishirPatil ShishirPatil mentioned this issue Sep 19, 2022
Merged
ShishirPatil added a commit that referenced this issue Sep 19, 2022
@ShishirPatil
Fixes #560 - aws s3 sync no-follow-symlink (#562)
24721d6 
aws s3 sync now --no-follow-symlink be default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShishirPatil ShishirPatil

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #560 - aws s3 sync no-follow-symlink skyplane-project/skyplane
2 participants
@parasj @ShishirPatil