Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to private IPs #585

Closed
sarahwooders opened this issue Sep 28, 2022 · 1 comment · Fixed by #607
Closed

Migrate to private IPs #585

sarahwooders opened this issue Sep 28, 2022 · 1 comment · Fixed by #607
Assignees
Labels
enhancement New feature or request

Comments

@sarahwooders
Copy link
Contributor

Currently by Skyplane uses public IPs, so transfers within a single provider will unnecessarily go over the internet and be subject to stricter bandwidth limits.

To fix this, I believe we need to modify https://github.com/skyplane-project/skyplane/blob/main/skyplane/compute/server.py#L266 to pass in the private IPs into outgoing_ports.

@sarahwooders sarahwooders added the enhancement New feature or request label Sep 28, 2022
@parasj
Copy link
Contributor

parasj commented Sep 28, 2022

@lynnliu030 This was an earlier attempt at private IPs for GCP (profiling only, not data plane): https://github.com/skyplane-project/skyplane/pull/325/files

Mainly, you will need to at least do the following:

@lynnliu030 lynnliu030 linked a pull request Oct 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants