Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#585: migrate to private ips #607

Merged
merged 2 commits into from
Oct 13, 2022
Merged

#585: migrate to private ips #607

merged 2 commits into from
Oct 13, 2022

Conversation

lynnliu030
Copy link
Contributor

@lynnliu030 lynnliu030 commented Oct 12, 2022

PR for #585.

Private ips for GCP throughput profiling is in #605

@lynnliu030 lynnliu030 linked an issue Oct 12, 2022 that may be closed by this pull request
Copy link
Contributor

@parasj parasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

skyplane/replicate/replicator_client.py Show resolved Hide resolved
@parasj
Copy link
Contributor

parasj commented Oct 13, 2022

Can you profile a typical GCP to GCP transfer before+after this change?

@lynnliu030
Copy link
Contributor Author

lynnliu030 commented Oct 13, 2022

@parasj Here's an example of transferring 9GB of data from gcp to gcp regions.

Before (using public ips): transfer runtime = 17.18s, throughput = 4.23 Gbps
image

After (using private ips): transfer runtime = 10.29s, throughput = 7.06 Gbps
image

There's around 1.7x throughput improvement and 40% runtime reduction

@parasj
Copy link
Contributor

parasj commented Oct 13, 2022

Great! glad to see it helps so much

Copy link
Contributor

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - feel free to merge!

@lynnliu030 lynnliu030 marked this pull request as ready for review October 13, 2022 06:09
@lynnliu030 lynnliu030 merged commit d6ffae4 into main Oct 13, 2022
@lynnliu030 lynnliu030 deleted the 585-migrate-to-private-ips branch October 13, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to private IPs
3 participants