-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration test on main, extract fallback CLI commands, add Azure fallback support and add sync fallback support #555
Conversation
Breaks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the performance logging client look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a design choice skyplane/cli/cli_impl/cp_replicate_fallback.py
introduces isolation but increases the surface area. Do we want to stick to this long term?
We should eventually migrate off of this in the future, but I want to isolate this functionality so we can swap implementation as you implement improved on-prem functionality. |
Fixes: #553
This PR makes several cleanups:
Integration test rerun pending: https://github.com/skyplane-project/skyplane/actions/runs/3075774286