Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure core import issue #613

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Fix Azure core import issue #613

merged 2 commits into from
Oct 17, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Oct 17, 2022

There are remaining Azure import issues with #589.

This PR fixes two issues with Azure:

  1. Uses dependency injection to lazily load Azure Core as suggested by @dbickson (skyplane init error: ModuleNotFoundError: No module named 'azure' #589 (comment))
  2. Check for Azure CLI during skyplane init

@parasj parasj added the bug Something isn't working label Oct 17, 2022
@parasj parasj self-assigned this Oct 17, 2022
@parasj parasj enabled auto-merge (squash) October 17, 2022 21:34
@parasj parasj mentioned this pull request Oct 17, 2022
Closed
@parasj parasj merged commit 473c995 into main Oct 17, 2022
@parasj parasj deleted the dev/fix_azure_core branch October 17, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@parasj parasj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@parasj