-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 #639
Conversation
@@ -41,7 +41,7 @@ Before you submit a pull request, make sure to complete the following steps: | |||
|
|||
.. code-block:: console | |||
|
|||
$ pip install black pytype autoflake | |||
$ pip install -r requirements-dev.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about:
poetry install --only dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an issue that Poetry requires Python version compliance with all dev dependencies and will not allow specification of a different Python version.
There's an in progress PR to add support for this, but it won't be production-ready for a while: python-poetry/poetry#5740
Several dev dependencies have not been updated for Python 3.11, most notably pytype which requires python >=3.7.1<3.11
.
Until that PR lands, an alternative solution is to extract development CLI dependencies into another file. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused with the use of poetry
in this project. I would opt for maintaining the pyproject.toml
with groups for dev
and gateway
instead of using a combination of poetry
, pip
, and requirements.txt
s.
Package management is a bit confusing:
|
Thanks for the explanation! |
@phi-line Thanks for the details feedback on these PRs. I just added you as a contributor to the project. Are you on the Skyplane Slack? https://join.slack.com/t/skyplaneworkspace/shared_invite/zt-1cxmedcuc-GwIXLGyHTyOYELq7KoOl6Q |
Changes: