Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.7 for config_paths #668

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Fix Python 3.7 for config_paths #668

merged 4 commits into from
Nov 15, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Nov 5, 2022

Fixes #667

@parasj parasj self-assigned this Nov 5, 2022
@sarahwooders
Copy link
Contributor

I'm getting this error on skyplane init and cp:

Traceback (most recent call last):
  File "/Users/sarahwooders/repos/skyplane/env/bin/skyplane", line 5, in <module>
    from skyplane.cli.cli import app
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.7/site-packages/skyplane/__init__.py", line 3, in <module>
    from skyplane import compute
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.7/site-packages/skyplane/compute/__init__.py", line 9, in <module>
    from skyplane.compute.gcp.gcp_cloud_provider import GCPCloudProvider
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.7/site-packages/skyplane/compute/gcp/gcp_cloud_provider.py", line 9, in <module>
    from skyplane.compute.gcp.gcp_network import GCPNetwork
  File "<fstring>", line 1
    (body=)
         ^
SyntaxError: invalid syntax

@parasj
Copy link
Contributor Author

parasj commented Nov 5, 2022

I can't install Python 3.7 on my Mac as it's ARM. I pushed another change to remove the unsupported fstring syntax. Can you try it one more time? I'm not able to test it locally.

There's a lot of small features that are unsupported on Python 3.7 that I added with the API PR.

@parasj parasj closed this Nov 5, 2022
@parasj parasj reopened this Nov 5, 2022
@parasj
Copy link
Contributor Author

parasj commented Nov 5, 2022

(whoops, closed the PR by mistake)

@parasj
Copy link
Contributor Author

parasj commented Nov 14, 2022

@sarahwooders I think this should fix Python 3.7 issues, but please check if so!

@sarahwooders
Copy link
Contributor

Yep was able to run skyplane init!

@sarahwooders sarahwooders merged commit bb16b0b into main Nov 15, 2022
@sarahwooders sarahwooders deleted the fix-667 branch November 15, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Error TypeError: Expected maxsize to be an integer or None when running skyplane
2 participants