Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#755] Add support for SEV provisioning in Azure #756

Merged
merged 3 commits into from
Feb 16, 2023
Merged

[#755] Add support for SEV provisioning in Azure #756

merged 3 commits into from
Feb 16, 2023
+75 −45

Conversation

zizhong
Copy link
Collaborator

@zizhong zizhong commented Feb 15, 2023

This fixed #755

Tested with azure_instance_class = Standard_DC2as_v5.

✓ Provisioning VMs (1/1) in 70.25s
✓ Starting gateway container on VMs (1/1) in 70.85s

✅ Transfer completed successfully
Transfer runtime: 3.00s, Throughput: 0.01Gbps

@zizhong zizhong self-assigned this Feb 15, 2023
@zizhong zizhong added the enhancement New feature or request label Feb 15, 2023
parasj
parasj approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@parasj parasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skyplane/compute/azure/azure_cloud_provider.py Outdated
@@ -96,6 +96,17 @@ def lookup_continent(region: str) -> str:
return continent
return "unknown"

@staticmethod
def use_confidential_instances(instance_name: str) -> bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to is_confidential_instance_type

@zizhong zizhong merged commit 1ed5562 into main Feb 16, 2023
@zizhong zizhong deleted the provison_cvm_azure branch February 16, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasj parasj parasj approved these changes

@ShishirPatil ShishirPatil Awaiting requested review from ShishirPatil

Assignees

@zizhong zizhong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] Add support for SEV provisioning in Azure
2 participants
@zizhong @parasj