Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Azure init issues #787

Merged
merged 18 commits into from
Apr 7, 2023
Merged

[Fix] Azure init issues #787

merged 18 commits into from
Apr 7, 2023

Conversation

zizhong
Copy link
Collaborator

@zizhong zizhong commented Apr 4, 2023

Fixing several Azure init issues as follows.

  1. The warning message aborts the skyplane init process "--scope argument will become required for creating a role assignment in the breaking change release of the fall of 2023. Please explicitly specify --scope."
⠇ Provisioning VMs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0/1 0:00:2523:52:12 [ERROR] Error running _provision_task: 'eastus'
Traceback (most recent call last):
  File "/home/zzz/workspace/skyplane/skyplane/cli/cli_transfer.py", line 382, in cp
    dp.provision(spinner=True)
  File "/home/zzz/workspace/skyplane/skyplane/api/dataplane.py", line 131, in provision
    uuids = self.provisioner.provision(
  File "/home/zzz/workspace/skyplane/skyplane/api/provisioner.py", line 205, in provision
    results: List[Tuple[ProvisionerTask, compute.Server]] = do_parallel(
  File "/home/zzz/workspace/skyplane/skyplane/utils/fn.py", line 57, in do_parallel
    args, result = future.result()
  File "/home/zzz/.pyenv/versions/3.8.10/lib/python3.8/concurrent/futures/_base.py", line 437, in result
    return self.__get_result()
  File "/home/zzz/.pyenv/versions/3.8.10/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception
  File "/home/zzz/.pyenv/versions/3.8.10/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/zzz/workspace/skyplane/skyplane/utils/fn.py", line 43, in wrapped_fn
    return args, func(args)
  File "/home/zzz/workspace/skyplane/skyplane/api/provisioner.py", line 154, in _provision_task
    server = self.azure.provision_instance(task.region, task.vm_type, use_spot_instances=task.spot, tags=task.tags)
  File "/home/zzz/workspace/skyplane/skyplane/utils/imports.py", line 33, in wrapped
    return fn(*modules_imported, *args, **kwargs)
  File "/home/zzz/workspace/skyplane/skyplane/compute/azure/azure_cloud_provider.py", line 356, in provision_instance
    "hardware_profile": {"vm_size": self.lookup_valid_instance(location, vm_size)},
  File "/home/zzz/workspace/skyplane/skyplane/compute/azure/azure_cloud_provider.py", line 113, in lookup_valid_instance
    if instance_name in sku_mapping:
KeyError: 'eastus'

@zizhong zizhong self-assigned this Apr 4, 2023
@zizhong zizhong requested a review from parasj April 4, 2023 01:28
@zizhong
Copy link
Collaborator Author

zizhong commented Apr 4, 2023

@parasj There is an issue in test-azure, saying "Cannot import azure.mgmt.quota.AzureQuotaExtensionAPI". Locally I installed azure-mgmt-quota and worked. However, the attempts of adding it to poetry failed where it seemed that poetry cannot resolve the version of package.

@sarahwooders
Copy link
Contributor

Thanks for adding this fix @zizhong - the fix looks good to me, but I'll look into what's causing the Azure test to fail tomorrow.

@sarahwooders sarahwooders merged commit 8faec33 into main Apr 7, 2023
@sarahwooders sarahwooders deleted the fix_azure_init branch April 7, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants