Refactor CLI transfer code and support local fallback #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces an API for Skyplane Broadcast Todos: - [x] Fix provisioning in BroadcastDataplane - Reuse provision loop via inheritance - Move `_start_gateway` to a class method and override it - Adapt broadcast to use `bound_nodes` - [x] Add BroadcastCopyJob (ideally extend CopyJob) - [x] Update tracker to monitor broadcast jobs - [x] Add multipart support - [x] Fix dependency issue via adding dockerfile and bc_requirements - [x] Integrate with gateway and test the monitoring side Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Sarah Wooders <[email protected]>
sarahwooders
requested review from
ShishirPatil and
parasj
and removed request for
ShishirPatil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transferred to/from local paths needs to fall back on cloud provider tools until we provide full support for this. I cleaned up the
skyplane cp/synccode to share a single function for shared logic for fallback options and initiating transfers.Remaining todo: add local tests to integration tests