Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that autocomplete does not refresh after book is saved #44

Open
skytreader opened this issue May 14, 2016 · 2 comments
Open

It seems that autocomplete does not refresh after book is saved #44

skytreader opened this issue May 14, 2016 · 2 comments
Labels
bug

Comments

@skytreader
Copy link
Owner

Particularly for content creators. Hence, the field of autocomplete suggestions is considerably narrowed down.
@skytreader skytreader added the bug label May 14, 2016
skytreader added a commit that referenced this issue May 20, 2016
@skytreader
Attempt for #44.
562cf17 
But won't be tested until I have to enter a new contributor more than once.

The problem is that the autocomplete list keeps the filtered lists even after
the book is submitted. Hence even if I'm adding in the names of new contributors
when the submission succeeds, the next entry is unable to benefit from it.
@skytreader
Copy link
Owner Author

Update: The original problem seems fixed. However there seems to be some new problems introduced :(. Keeping this open for documentation of this trail.

New problems:

  • Added "Alighieri, Dante", a new author. In the same session, "Alighieri" is available for autocomplete on lastname fields but "Dante" is not (or, at least, it does not filter so).
  • Added "Ciardi, John", a new translator. In the same session, "Ciardi" is not even available for autocomplete.

skytreader added a commit that referenced this issue Jun 12, 2016
@skytreader
More attempts for #44.
d8d711c 
Also, I think I really need to OO the shit out of this!
skytreader added a commit that referenced this issue Jun 12, 2016
@skytreader
Fix "New problems" in #44.
f191e48 
Still needs observation to verify correctness though.
@skytreader
Copy link
Owner Author

More new problems:

Autocomplete entries are re-added even if they are already in the autocomplete options. Sample: "Eco, Umberto" already existing but adding another book by the same author will add another autocomplete entry for it. Hence, next time, there are two "Eco"s and "Umberto"s in the autocomplete prompt.

eco
umberto

skytreader added a commit that referenced this issue Nov 7, 2017
@skytreader
Failed attempt for #44.
295fed1
skytreader added a commit that referenced this issue Nov 7, 2017
@skytreader
resetAutocomplete only once after a book is entered.
08f3d91 
Also add some inline documentation for #44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skytreader