Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix iOS8 wrong popover size in iPad #25

Merged
merged 1 commit into from
Aug 26, 2014
Merged

fix iOS8 wrong popover size in iPad #25

merged 1 commit into from
Aug 26, 2014

Conversation

AdrianFlorian
Copy link

No description provided.

This was referenced Aug 26, 2014
Closed
Closed
@skywinder skywinder merged commit 30ee9b2 into skywinder:master Aug 26, 2014
@skywinder
Copy link
Owner

Thanks a lot! 👍
Also, check out my improvements for your fix.

  1. (It's better to not hardcode some constants (like 260)
  2. Since I still support iOS 6 - I added additional check, beacuse preferredContentSize avaliable from iOS 7.

@AdrianFlorian
Copy link
Author

Agree, that’s great, thanks!

On Aug 26, 2014, at 10:29 AM, Petr Korolev [email protected] wrote:

Thanks a lot!
Also, check out my improvements for your fix.

  1. (It's better to not hardcode some constants (like 260)
  2. Since I still support iOS 6 - I added additional check, beacuse preferredContentSize avaliable from iOS 7.

—
Reply to this email directly or view it on GitHub.

@skywinder skywinder mentioned this pull request Aug 26, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrianFlorian @skywinder