Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run ActionSheetPickerTests on Xcode and Travis CI #393

Merged
merged 3 commits into from
Apr 20, 2018

Conversation

nowsprinting
Copy link

  • Remove shared scheme ActionSheetPickerTests (need only on build target)
  • Remove TestTableViewController.m from build target ActionSheetPickerTests's membership
  • Fix .travis.yml
    • Remove commented-out lines
    • Fix specified scheme name
    • Add osx_image
    • Add -destination option on xcodebuild command
  • Fix tests
    • Fix duplicate global field (UIView)origin

@saad352
Copy link

saad352 commented Apr 17, 2018

Any idea when this pull request will be merged?
The main developers doesn't seem to be active.

@nowsprinting
Copy link
Author

@saad352 This repository owner looks active to me.
I think that it will be merged someday, so I will wait. (and pray...)

@skywinder
Copy link
Owner

@nowsprinting yay! thank a lot. I'm very appreciated for that fix!
Sorry for a long answer. I'm fully on other project and sometimes miss the PR's here.

@skywinder skywinder merged commit c78d7a8 into skywinder:develop Apr 20, 2018
@nowsprinting
Copy link
Author

@skywinder Thanks!

@nowsprinting nowsprinting deleted the fix_tests branch April 20, 2018 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants