-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for UIDatePickerModeCountDownTimer callback #50
Conversation
If presenting an ActionSheetDatePicker with a datePickerMode of UIDatePickerModeCountDownTimer, currently returns the current date in the callback. In this instance, would be much better to return the duration as that is what the user is picking, not a date
Heya, just found a small bug in the date picker which is different from the pre-3.0 version (which was how I found it after I upgraded). Let me know what you think, thanks! |
If user taps “done” without picking a time, currently returns a callback of 0 seconds though this is incorrect as the default selection in the popup is 1 minute (note, user also can’t select 0 minutes). Fixed so when date picker first instantiated, will set the selected duration as 60 seconds
Apologies, please see next pull request which has a minor bug fix |
Ok clearly I don't know how pull requests work on github (I didn't realise they automatically get added together) - see re-opened pull request with 2 commits this time :) |
@jklp Thanks! I'll review it soon. |
Fix for UIDatePickerModeCountDownTimer callback
You also forgot to add countdownDuration support to block-based callbacks. |
- Remove unused init function. - Add CountDownTimer support to blocks. - Remove redudant countDownDuration init
If presenting an ActionSheetDatePicker with a datePickerMode of
UIDatePickerModeCountDownTimer, currently returns the current date in
the callback.
In this instance, would be much better to return the duration as that
is what the user is picking, not a date