Fix for UIDatePickerModeCountDownTimer callback #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If presenting an ActionSheetDatePicker with a datePickerMode of UIDatePickerModeCountDownTimer, currently returns the current date in the callback. In this instance, would be much better to return the duration as that is what the user is picking, not a date
|
Heya, just found a small bug in the date picker which is different from the pre-3.0 version (which was how I found it after I upgraded). Let me know what you think, thanks! |
If user taps “done” without picking a time, currently returns a callback of 0 seconds though this is incorrect as the default selection in the popup is 1 minute (note, user also can’t select 0 minutes). Fixed so when date picker first instantiated, will set the selected duration as 60 seconds
|
Apologies, please see next pull request which has a minor bug fix |
|
Ok clearly I don't know how pull requests work on github (I didn't realise they automatically get added together) - see re-opened pull request with 2 commits this time :) |
|
@jklp Thanks! I'll review it soon. |
skywinder
added a commit
that referenced
this pull request
Sep 29, 2014
Fix for UIDatePickerModeCountDownTimer callback
|
You also forgot to add countdownDuration support to block-based callbacks. |
skywinder
added a commit
that referenced
this pull request
Oct 15, 2014
- Remove unused init function. - Add CountDownTimer support to blocks. - Remove redudant countDownDuration init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If presenting an ActionSheetDatePicker with a datePickerMode of
UIDatePickerModeCountDownTimer, currently returns the current date in
the callback.
In this instance, would be much better to return the duration as that
is what the user is picking, not a date