Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 14 default datePickerStyle = wheels when not set in the app, Fixes Issue #491 (Background tap) #502

Merged
merged 2 commits into from
Sep 27, 2020
Merged

iOS 14 default datePickerStyle = wheels when not set in the app, Fixes Issue #491 (Background tap) #502

merged 2 commits into from
Sep 27, 2020

Conversation

noorulain17
Copy link
Collaborator

@noorulain17 noorulain17 commented Sep 24, 2020 •
edited
Loading

  • iOS 14 default datePickerStyle = wheels
  • Added background tap gesture to dismiss picker view - #491 - Background tap issue
  • Dynamic Height for DatePickerStyle-Inline only (iOS 14.0 specific)

Screenshot 2020-09-24 at 2 05 06 PM

Screenshot 2020-09-24 at 3 38 05 PM

Screenshot 2020-09-24 at 9 14 09 PM

Screenshot 2020-09-24 at 3 52 40 PM

Screenshot 2020-09-24 at 3 52 47 PM

@skywinder
Copy link
Owner

Perfect! thank you very much!
looks great. I think we can merge it! 👍

@noorulain17
Copy link
Collaborator Author

Thanks. I still couldn't figure out the issue why the datePicker width is less than the view width in iOS 14.0.
Besides that, other issues are solved.

@noorulain17 noorulain17 mentioned this pull request Sep 24, 2020
Closed
@skywinder
Copy link
Owner

Yay! looks great, thank you! 👍

skywinder
skywinder approved these changes Sep 27, 2020
View reviewed changes
Copy link
Owner

@skywinder skywinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge

@skywinder skywinder merged commit c1425aa into develop Sep 27, 2020
@noorulain17 noorulain17 deleted the ios14 branch September 27, 2020 13:12
@skywinder skywinder restored the ios14 branch September 27, 2020 13:15
@skywinder skywinder mentioned this pull request Sep 27, 2020
Closed
@ivan-magda ivan-magda mentioned this pull request Sep 28, 2020
Closed
@noorulain17 noorulain17 mentioned this pull request Sep 28, 2020
Closed
@noorulain17 noorulain17 deleted the ios14 branch October 1, 2020 15:33
@skywinder skywinder restored the ios14 branch October 7, 2020 17:05
@noorulain17 noorulain17 deleted the ios14 branch October 26, 2020 08:30
@noorulain17 noorulain17 changed the title iOS 14 default datePickerStyle = wheels when not set in the app iOS 14 default datePickerStyle = wheels when not set in the app, Fixed #491 Dec 19, 2020
@noorulain17 noorulain17 changed the title iOS 14 default datePickerStyle = wheels when not set in the app, Fixed #491 iOS 14 default datePickerStyle = wheels when not set in the app, Fixes Issue #491 (Background tap) Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skywinder skywinder skywinder approved these changes

@KunzManuel KunzManuel Awaiting requested review from KunzManuel

Assignees
No one assigned
Labels
iOS14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noorulain17 @skywinder