Bottom padding for iPhone X style phones #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the home bar). Using keyWindow.safeAreaInsets.bottom
|
Thank you very much! 👍 |
ghost
reviewed
Oct 12, 2020
Comment on lines
+257
to
+260
| if (@available(iOS 11.0, *)) { | ||
| UIWindow *window = UIApplication.sharedApplication.keyWindow; | ||
| height += window.safeAreaInsets.bottom; | ||
| } |
There was a problem hiding this comment.
keyWindow is deprecated
https://stackoverflow.com/questions/57134259/how-to-resolve-keywindow-was-deprecated-in-ios-13-0
fyi @skywinder @palmtrae
There was a problem hiding this comment.
True, there's more examples of this in the code base. Should probably open a new issue with this in mind to add scene support for iPads.
There was a problem hiding this comment.
Agree. It would be nice if someone can deal with is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the ActionSheet renders behind the home bar.