-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow DOM support and tests #2337
Conversation
Tests are failing in Safari because not implemented |
c6a20bb
to
053c878
Compare
Shadow selection polyfill does not work properly because of this line: https://github.com/quilljs/quill/blob/96e38e92637b75b907579d0cc1b201920aebe38c/core/selection.js#L32 See the listener in the polyfill where |
2bacde8
to
e3b0eb6
Compare
What's the progress on this issue? I tried using quill on a polymer project a couple of months ago and unfortunately I was not able to get it to work. :( Is there anything I can do to help? I really look forward to using quill in my projects! EDIT: I just noticed #1805, I'll take a look and hopefully take a shot at helping out. |
Is this support for Shadow DOM still actively worked on? I see #1805 has also been open for a while. |
Note, the polyfill for Safari added in this PR mostly works but is not quite stable (as we have observed various issues with Quill which it introduces). Furthermore, the selection API has to be changed so that there will be |
@web-padawan -- I need to get this working yesterday. And I'd like to spend some time on it.
Thanks |
@DeadWisdom the problem is described here webcomponents/polyfills#66 (comment) In our project, we ended up using a fork with custom build, source is here: That branch is derived from The commits below are especially targeting the issue in Safari, so you should be able to apply these patches on top of Note, the polyfill used by our project is not official, neither 100% tested. We consider it "good enough" to make Quill work in Shadow DOM in Safari but some edge cases will occur. |
Thank you very much @web-padawan for your work on this. I've been given a small sandbox of time to get this done. So we'll see what I can do. |
@DeadWisdom updates? |
Ping? Anything we can do to get this merged? |
I ended up working on this problem elsewhere, one thing missing from this PR is properly handling the |
It's almost 2023? any updates on support or a forked latest npm package etc? |
Rebased the work from #1805 on top of the
1.3.6
Submitting this PR to check if the tests pass