-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note concerning replying in a thread #168
Conversation
README.md
Outdated
You can reply to a message in a thread (or keep sending to the current thread) : | ||
|
||
```ruby | ||
command('reply in thread') do |client, data, match| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the parentheses for consistency with the rest of the documentation
README.md
Outdated
client.say( | ||
channel: data.channel, | ||
text: "let's avoid spamming everyone, I will tell you what you need in this thread", | ||
thread_ts: (data.thread_ts || data.ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parentheses not needed here either
README.md
Outdated
@@ -106,6 +106,21 @@ end | |||
|
|||
Operator match data includes `match['operator']` and `match['expression']`. The `bot` match always checks against the `SlackRubyBot::Config.user` setting. | |||
|
|||
You can reply to a message in a thread (or keep sending to the current thread) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should have it's own section, like ### Threaded Messages
also Harmonize code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor nitpicks please.
README.md
Outdated
@@ -106,6 +106,23 @@ end | |||
|
|||
Operator match data includes `match['operator']` and `match['expression']`. The `bot` match always checks against the `SlackRubyBot::Config.user` setting. | |||
|
|||
### Threaded Messages | |||
|
|||
You can reply to a message in a thread (or keep sending to the current thread) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: why a space before :
?
client.say( | ||
channel: data.channel, | ||
text: "let's avoid spamming everyone, I will tell you what you need in this thread", | ||
thread_ts: data.thread_ts || data.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment to what these are? Maybe a link to docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello sorry for the long wait. I'm a French guy so sometimes I forget there is no space before semicolons in english ^^"
I have included extra information and links regarding thread_ts
and ts
.
Sorry for stalling this PR for so long
Closed via 162b9e0 |
For #131