Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update terminology #42

Merged
merged 4 commits into from
Aug 22, 2024
Merged

chore: update terminology #42

merged 4 commits into from
Aug 22, 2024

Conversation

WilliamBergamin
Copy link
Contributor

Type of change (place an x in the [ ] that applies)

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR update the terminology of this project to be consistent across all our surfaces

Requirements (place an x in each [ ] that applies)

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@WilliamBergamin WilliamBergamin added the update PR only - an update or maintenance is being made to an existing app label Aug 22, 2024
@WilliamBergamin WilliamBergamin self-assigned this Aug 22, 2024
Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some thoughts. Same consideration as the last PR: if these are referenced in our docs (code snippets in tutorials), it needs to be changed there, too.

In general, we need to be mindful of when to use function versus step: it's still function when it comes to the event itself, and that's unlikely going to change!

app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once more! I left a question about the repo naming that we might want to match between PRs and a thought on "steps" in errors, but nothing blocking 🚀

README.md Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
Co-authored-by: Eden Zimbelman <[email protected]>
@WilliamBergamin WilliamBergamin merged commit d8d7798 into main Aug 22, 2024
3 checks passed
@WilliamBergamin WilliamBergamin deleted the update-terminology branch August 22, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update PR only - an update or maintenance is being made to an existing app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants