Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1148 - Adjust the app.message listener interface in TypeScript to compile the examples in documents #1185

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Fix #1148 - Adjust the app.message listener interface in TypeScript to compile the examples in documents #1185

merged 3 commits into from
Nov 2, 2021

Commits on Nov 1, 2021

  1. Add type alias for Middleware<SlackEventMiddlewareArgs<'message'>> in… 

    … `App`
    @M1kep
    M1kep committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    74ec6bd View commit details
    Browse the repository at this point in the history

  2. Add additional overloads and comment based docs for App.message 

    To open this method up to TypeScript users a required either removing the two existing overloads, or creating new overloads. Hopefully by providing additional overloads as well as inline documentation, this can provide assistance as well as control

Fixes slackapi#1148
    @M1kep
    M1kep committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    88e0cf1 View commit details
    Browse the repository at this point in the history

  3. Add App#message Tests

    @M1kep
    M1kep committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    ed9de56 View commit details
    Browse the repository at this point in the history