Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1364 Update axios to latest 0.26.1 #1366

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 11, 2022

Summary

This pull request resolves #1364. Also, it fixes a minor warnings for devDependencies.

Requirements (place an x in each [ ])

@seratch seratch added this to the 3.11.0 milestone Mar 11, 2022
@seratch seratch self-assigned this Mar 11, 2022
@@ -70,7 +70,10 @@
"eslint-config-airbnb-typescript": "^12.3.1",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-jsdoc": "^30.6.1",
"eslint-plugin-jsx-a11y": "^6.5.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix:

npm WARN [email protected] requires a peer of eslint-plugin-jsx-a11y@^6.4.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-react@^7.21.5 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-react-hooks@^4 || ^3 || ^2.3.0 || ^1.7.0 but none is installed. You must install peer dependencies yourself.

@seratch seratch mentioned this pull request Mar 11, 2022
6 tasks
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1366 (6f86eaf) into main (b151b4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   72.76%   72.76%           
=======================================
  Files          17       17           
  Lines        1465     1465           
  Branches      436      436           
=======================================
  Hits         1066     1066           
  Misses        310      310           
  Partials       89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b151b4c...6f86eaf. Read the comment docs.

@seratch seratch merged commit 4288c1e into slackapi:main Mar 12, 2022
@seratch seratch deleted the issue-1364 branch March 12, 2022 00:12
@seratch
Copy link
Member Author

seratch commented Mar 12, 2022

We can do the same for web-api package later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update axios to latest 0.26.1
2 participants