Fixes failing tests: block_actions.user.name is optional #1916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #1910 :
block_actions
payloads can send both ausername
as well asname
field, depending on where the action originates from.name
will be present if the action was sent from the Home tab. See the Examples on theblock_actions
documentation for details.This also fixes (well, hopefully! the CI will be the judge of that) the currently-failing tests on
main
. On GitHub CI the build was failing because GitHub was using v2.28.0 of the eslint-import-plugin, whereas on my machine (where I could not reproduce it) was using v2.27.5.