Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-build.yml - add codecov upload token #1952

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Sep 18, 2023

Adds repository upload token to git action

Summary

Public repositories shouldn't technically require a token to upload to codecov. However, we are seeing failing this PR for example here. Per recommendation here, adding an explicit token to see whether that makes the situation better.

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

Adds repository upload token to git action
@srajiang srajiang self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1952 (f1fc451) into main (d088ec8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1952   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          18       18           
  Lines        1521     1521           
  Branches      436      436           
=======================================
  Hits         1250     1250           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srajiang srajiang requested a review from zimeg September 18, 2023 16:38
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I'm hopeful that the token will fix this, nice find! 🔍

We might also want to add the CODECOV_TOKEN secret to the Dependabot section of secrets too – not sure if this token is shared between the normal Actions secrets 🤔

@srajiang
Copy link
Member Author

@zimeg - Thanks, yep added to the Dependabot section as well. Merging and fingies crossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants