Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an example of using middleware with the ExpressReceiver #1973

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Oct 16, 2023

Summary

This PR adds an example of using middleware in web requests with the ExpressReceiver to the custom routes documentation.

Notes

  • As always, very open to any suggestions, changes, removals, or additions.
  • Any help with the translations would also be very appreciated!

Requirements

@zimeg zimeg added docs M-T: Documentation work only semver:patch labels Oct 16, 2023
@zimeg zimeg self-assigned this Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1973 (9648add) into main (f104c0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1973   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files          18       18           
  Lines        1524     1524           
  Branches      438      438           
=======================================
  Hits         1253     1253           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -86,7 +91,7 @@ receiver.router.post('/secret-page', (req, res) => {

(async () => {
await app.start();
console.log('⚡️ Bolt app started'');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch seratch added this to the 3.14.1 milestone Oct 17, 2023
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimeg
Copy link
Member Author

zimeg commented Oct 18, 2023

@seratch @WilliamBergamin Appreciate the reviews, thank you! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants