Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to JS release notes #2239

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Link to JS release notes #2239

merged 1 commit into from
Sep 6, 2024

Conversation

bpfoster
Copy link
Contributor

@bpfoster bpfoster commented Sep 6, 2024

Summary

Fixes release notes link in documentation. JavaScript documentation should link to bolt-js release notes, not bolt-python release notes.

Requirements (place an x in each [ ])

Javascript documentation should link to bolt-js release notes, not bolt-python release notes.
Copy link

salesforce-cla bot commented Sep 6, 2024

Thanks for the contribution! Before we can merge this, we need @bpfoster to sign the Salesforce Inc. Contributor License Agreement.

@bpfoster
Copy link
Contributor Author

bpfoster commented Sep 6, 2024

I have signed the CLA but the status is not reflected here. Attempting to re-sign it gives me: "You already signed the CLA on 2024-09-06"

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (de08aaa) to head (3a5664a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2239   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files          19       19           
  Lines        1646     1646           
  Branches      464      464           
=======================================
  Hits         1343     1343           
  Misses        194      194           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filmaj
Copy link
Contributor

filmaj commented Sep 6, 2024

I can confirm the CLA is signed on our end. Sorry about that! Will raise the issue internally at Salesforce.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@filmaj filmaj merged commit e534f8a into slackapi:main Sep 6, 2024
19 of 20 checks passed
@bpfoster bpfoster deleted the patch-1 branch September 6, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants