chore(deps): upgrade path-to-regexp to address a security vulnerability
#2251
+24
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
added
security
semver:patch
dependencies
filmaj
force-pushed
the
path-to-regexp
branch
from
3d5e0dc
to
46d282c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
=======================================
Coverage 87.78% 87.78%
=======================================
Files 19 19
Lines 1646 1646
Branches 464 464
=======================================
Hits 1445 1445
Misses 194 194
Partials 7 7 ☔ View full report in Codecov by Sentry. |
filmaj
commented
Sep 11, 2024
| }, | ||
| "scripts": { | ||
| "prepare": "npm run build", | ||
| "build": "tsc", |
There was a problem hiding this comment.
Ensure we clean out the dist/ directory of transpiled files to be published first before building.
filmaj
commented
Sep 11, 2024
| @@ -21,12 +21,12 @@ | |||
| "dist/**/*" | |||
| ], | |||
| "engines": { | |||
| "node": ">=12.13.0", | |||
| "npm": ">=6.12.0" | |||
| "node": ">=14.21.3", | |||
There was a problem hiding this comment.
These values are based on the node JS release schedule, and the latest patch version of node 14 that is available (but also EOL) as well as the npm version bundled with it.
filmaj
commented
Sep 11, 2024
| @@ -1,68 +1,28 @@ | |||
| { | |||
| "$schema": "https://json.schemastore.org/tsconfig", | |||
| "compilerOptions": { | |||
| /* Basic Options */ | |||
There was a problem hiding this comment.
Cleaning this file up so that JSON LSPs can deal with them - comments are not valid JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes #2242