Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut v2 #428

Merged
merged 65 commits into from
Mar 24, 2020
Merged

Shortcut v2 #428

merged 65 commits into from
Mar 24, 2020

Conversation

stevengill
Copy link
Member

Summary

Adding new shortcut method

Requirements (place an x in each [ ])

seratch and others added 30 commits January 30, 2020 12:31
Fix slackapi#168 slackapi#354 Add `logger`, `client` to the list of args send through to listeners
Fix slackapi#382 Missing invite_requested event type
Fix slackapi#355 - processMiddleware doesn't wait for last global middleware's call to `next()`
* specifies view submission response action types for use in .view() listener acks
* fixes view submission state by adding values property
Fix slackapi#348 app.view() is not described in the README
Fix slackapi#405 by providing a better way to configure logger
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #428 into @slack/bolt@next will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           @slack/bolt@next     #428   +/-   ##
=================================================
  Coverage             85.10%   85.10%           
=================================================
  Files                     7        7           
  Lines                   537      537           
  Branches                158      158           
=================================================
  Hits                    457      457           
  Misses                   52       52           
  Partials                 28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62975af...62975af. Read the comment docs.

Copy link
Member Author

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doc changes to make

docs/_basic/listening_actions.md Outdated Show resolved Hide resolved
docs/_basic/listening_responding_shortcuts.md Outdated Show resolved Hide resolved
docs/_tutorials/getting_started.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aoberoi aoberoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of little things but the bones look great!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/maintainers_guide.md Show resolved Hide resolved
docs/_advanced/receiver.md Outdated Show resolved Hide resolved
src/App.spec.ts Outdated Show resolved Hide resolved
src/App.ts Outdated Show resolved Hide resolved
src/App.ts Show resolved Hide resolved
src/helpers.spec.ts Outdated Show resolved Hide resolved
src/helpers.ts Show resolved Hide resolved
Copy link
Contributor

@aoberoi aoberoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was fast!

@stevengill stevengill merged commit 961257b into slackapi:@slack/bolt@next Mar 24, 2020
@stevengill stevengill deleted the shortcutV2 branch May 22, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants