Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #598 add async to v2 migration guide global error handler example #599

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Fix #598 add async to v2 migration guide global error handler example #599

merged 2 commits into from
Aug 26, 2020

Conversation

atl-mk
Copy link
Contributor

@atl-mk atl-mk commented Aug 25, 2020

Summary

Fixes #598

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Aug 25, 2020
@CLAassistant
Copy link

CLAassistant commented Aug 25, 2020

CLA assistant check
All committers have signed the CLA.

@atl-mk atl-mk changed the title #598: add async to v2 migration guide global error handler example #598 add async to v2 migration guide global error handler example Aug 25, 2020
@atl-mk atl-mk changed the title #598 add async to v2 migration guide global error handler example issue #598 add async to v2 migration guide global error handler example Aug 25, 2020
@atl-mk atl-mk changed the title issue #598 add async to v2 migration guide global error handler example Fix #598 add async to v2 migration guide global error handler example Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #599 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files           7        7           
  Lines         598      598           
  Branches      193      193           
=======================================
  Hits          498      498           
  Misses         67       67           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2a6a3...f51f9ca. Read the comment docs.

@seratch
Copy link
Member

seratch commented Aug 25, 2020

Thanks! If you don't mind, could you make the same change to this file? https://github.com/slackapi/bolt-js/blob/%40slack/bolt%402.3.0/docs/_tutorials/ja_migration_v2.md

@seratch seratch added docs M-T: Documentation work only and removed untriaged labels Aug 25, 2020
@seratch
Copy link
Member

seratch commented Aug 26, 2020

Alright, I can work on the Japanese doc. I will merge this within a few hours.

@atl-mk
Copy link
Contributor Author

atl-mk commented Aug 26, 2020

Thanks! If you don't mind, could you make the same change to this file? https://github.com/slackapi/bolt-js/blob/%40slack/bolt%402.3.0/docs/_tutorials/ja_migration_v2.md

Done

@atl-mk
Copy link
Contributor Author

atl-mk commented Aug 26, 2020

Alright, I can work on the Japanese doc. I will merge this within a few hours.

Oh, whoops 🤭

@seratch
Copy link
Member

seratch commented Aug 26, 2020

Thanks! I haven't started working on it 😄

@seratch seratch merged commit 12d767c into slackapi:main Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to v2 tutorial error handler is not an async function
3 participants