-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #598 add async to v2 migration guide global error handler example #599
Fix #598 add async to v2 migration guide global error handler example #599
Conversation
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 83.27% 83.27%
=======================================
Files 7 7
Lines 598 598
Branches 193 193
=======================================
Hits 498 498
Misses 67 67
Partials 33 33 Continue to review full report at Codecov.
|
Thanks! If you don't mind, could you make the same change to this file? https://github.com/slackapi/bolt-js/blob/%40slack/bolt%402.3.0/docs/_tutorials/ja_migration_v2.md |
Alright, I can work on the Japanese doc. I will merge this within a few hours. |
Done |
Oh, whoops 🤭 |
Thanks! I haven't started working on it 😄 |
Summary
Fixes #598
Requirements (place an
x
in each[ ]
)